| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202412070636.sTYakaSQ-lkp@intel.com>
Date: Mon, 9 Dec 2024 11:40:04 +0800
From: kernel test robot <lkp@...el.com>
To: Mikael Gonella-Bolduc via B4 Relay <devnull+mgonellabolduc.dimonoff.com@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Bill Wendling <morbo@...gle.com>,
Justin Stitt <justinstitt@...gle.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Mikael Gonella-Bolduc <m.gonella.bolduc@...il.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
Matti Vaittinen <mazziesaccount@...il.com>
Subject: Re: [PATCH v2 2/2] iio: light: Add APDS9160 ALS & Proximity sensor
driver
Hi Mikael,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 5de07b8a24cf44cdb78adeab790704bf577c2c1d]
url: https://github.com/intel-lab-lkp/linux/commits/Mikael-Gonella-Bolduc-via-B4-Relay/dt-bindings-iio-light-Add-APDS9160-binding/20241207-001144
base: 5de07b8a24cf44cdb78adeab790704bf577c2c1d
patch link: https://lore.kernel.org/r/20241206-apds9160-driver-v2-2-be2cb72ef8f4%40dimonoff.com
patch subject: [PATCH v2 2/2] iio: light: Add APDS9160 ALS & Proximity sensor driver
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241207/202412070636.sTYakaSQ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241207/202412070636.sTYakaSQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412070636.sTYakaSQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/iio/light/apds9160.c:12:
In file included from include/linux/i2c.h:13:
In file included from include/linux/acpi.h:14:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/iio/light/apds9160.c:16:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:14:
In file included from arch/s390/include/asm/io.h:95:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from drivers/iio/light/apds9160.c:16:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:14:
In file included from arch/s390/include/asm/io.h:95:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from drivers/iio/light/apds9160.c:16:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:14:
In file included from arch/s390/include/asm/io.h:95:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:693:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
693 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:701:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
701 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:709:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
709 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:718:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
718 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:727:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
727 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:736:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
736 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
>> drivers/iio/light/apds9160.c:986:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
986 | default:
| ^
drivers/iio/light/apds9160.c:986:3: note: insert 'break;' to avoid fall-through
986 | default:
| ^
| break;
>> drivers/iio/light/apds9160.c:256:18: warning: unused variable 'apds9160_als_gain_avail' [-Wunused-const-variable]
256 | static const int apds9160_als_gain_avail[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~
18 warnings generated.
vim +986 drivers/iio/light/apds9160.c
889
890 static int apds9160_read_raw(struct iio_dev *indio_dev,
891 struct iio_chan_spec const *chan, int *val,
892 int *val2, long mask)
893 {
894 struct apds9160_chip *data = iio_priv(indio_dev);
895 int ret = -EINVAL;
896
897 switch (mask) {
898 case IIO_CHAN_INFO_RAW:
899 switch (chan->type) {
900 case IIO_PROXIMITY: {
901 __le16 buf;
902
903 ret = regmap_bulk_read(data->regmap, chan->address,
904 &buf, 2);
905 if (ret)
906 return ret;
907
908 ret = IIO_VAL_INT;
909 *val = le16_to_cpu(buf);
910 /* Remove overflow bits from result */
911 *val = FIELD_GET(APDS9160_PS_DATA_MASK, *val);
912 } break;
913 case IIO_LIGHT:
914 case IIO_INTENSITY: {
915 u8 buf[3];
916
917 ret = regmap_bulk_read(data->regmap, chan->address,
918 &buf, 3);
919 if (ret)
920 return ret;
921
922 ret = IIO_VAL_INT;
923 *val = get_unaligned_le24(buf);
924 } break;
925 case IIO_CURRENT:
926 ret = IIO_VAL_INT;
927 *val = data->ps_current;
928 break;
929 default:
930 break;
931 }
932 break;
933 case IIO_CHAN_INFO_HARDWAREGAIN:
934 switch (chan->type) {
935 case IIO_LIGHT:
936 ret = IIO_VAL_INT;
937 *val = data->als_hwgain;
938 break;
939 case IIO_PROXIMITY:
940 ret = IIO_VAL_INT;
941 *val = data->ps_gain;
942 break;
943 default:
944 break;
945 }
946 break;
947 case IIO_CHAN_INFO_INT_TIME:
948 switch (chan->type) {
949 case IIO_LIGHT:
950 ret = IIO_VAL_INT;
951 *val = data->als_itime;
952 break;
953 default:
954 break;
955 }
956 break;
957 case IIO_CHAN_INFO_SAMP_FREQ:
958 switch (chan->type) {
959 case IIO_PROXIMITY:
960 ret = IIO_VAL_INT;
961 *val = data->ps_rate;
962 break;
963 default:
964 break;
965 }
966 break;
967 case IIO_CHAN_INFO_CALIBSCALE:
968 switch (chan->type) {
969 case IIO_PROXIMITY:
970 ret = IIO_VAL_INT;
971 *val = data->ps_cancellation_level;
972 break;
973 default:
974 break;
975 }
976 break;
977 case IIO_CHAN_INFO_CALIBBIAS:
978 switch (chan->type) {
979 case IIO_PROXIMITY:
980 ret = IIO_VAL_INT;
981 *val = data->ps_cancellation_analog;
982 break;
983 case IIO_CURRENT:
984 ret = IIO_VAL_INT;
985 *val = data->ps_cancellation_current;
> 986 default:
987 break;
988 }
989 break;
990 case IIO_CHAN_INFO_SCALE:
991 switch (chan->type) {
992 case IIO_LIGHT:
993 ret = IIO_VAL_INT_PLUS_MICRO;
994 *val = data->als_scale1;
995 *val2 = data->als_scale2;
996 break;
997 default:
998 break;
999 }
1000 break;
1001 default:
1002 break;
1003 }
1004
1005 return ret;
1006 };
1007
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists