linux-kernel - Re: [PATCH 07/10] of: Correct comments for of_alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05251181-9b8a-496d-8439-d03460b2fe42@icloud.com>
Date: Mon, 9 Dec 2024 21:41:27 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Rob Herring <robh@...nel.org>
Cc: Saravana Kannan <saravanak@...gle.com>,
 Leif Lindholm <leif.lindholm@...aro.org>,
 Stephen Boyd <stephen.boyd@...aro.org>, Maxime Ripard <mripard@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Grant Likely
 <grant.likely@...retlab.ca>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH 07/10] of: Correct comments for of_alias_scan()

On 2024/12/9 21:20, Rob Herring wrote:
>> - Replace /* with /** to start comments since it is not a API.
> But it is because it's in of.h. However, you are correct in that it
> has no external callers. So please move the declaration to
> of_private.h.
> 

thank you Rob for code review.
let me do it in next revision.

>> - Delete return value descriptions since it is a void function.