linux-kernel - Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241209005713.52352-1-ole0811sch@gmail.com>
Date: Mon,  9 Dec 2024 01:57:13 +0100
From: Ole Schuerks <ole0811sch@...il.com>
To: mcgrof@...nel.org
Cc: deltaone@...ian.org,
	jan.sollmann@....de,
	jude.gyimah@....de,
	linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	masahiroy@...nel.org,
	nathan@...nel.org,
	nicolas@...sle.eu,
	ole0811sch@...il.com,
	thorsten.berger@....de
Subject: Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface

Thanks for all the feedback.

> This just deals with the first error and there is no unwinding, is that OK?

This should be OK. dlsym() only retrieves the address of a symbol from an
already loaded object. The calls to dlsym() thus should not need to be
unwound, it's sufficient to unload the object via dlclose().

> Other than that, did you run this through checkpatch.pl?

I ran all patches through checkpath.pl. The only reported issues with this
patch are the ones related to the use of the X-macro and one about the
typedef for the PicoSAT type. Is the use of X-macros discouraged?
Refactoring it wouldn't be a problem. (I think it makes most sense to keep
the typedef, though, in order to keep the declarations compatible with
those from the original header file.)

Best regards,
Ole Schuerks