linux-kernel - Re: [PATCH] wifi: wlcore: fix unbalanced pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173375947536.157598.1252176440647591956.kvalo@kernel.org>
Date: Mon,  9 Dec 2024 15:51:16 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: rmk+kernel@...linux.org.uk, johannes.berg@...el.com, andreas@...nade.info,
 leitao@...ian.org, emmanuel.grumbach@...el.com,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: wlcore: fix unbalanced pm_runtime calls

Andreas Kemnade <andreas@...nade.info> wrote:

> If firmware boot failes, runtime pm is put too often:
> [12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
> [12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
> Fix that by redirecting all error gotos before runtime_get so that runtime is not put.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

Do we know what commit broke this? A Fixes tag would be good to have.

Why not change this also to use out_unlock:

	role_type = wl12xx_get_role_type(wl, wlvif);
	if (role_type == WL12XX_INVALID_ROLE_TYPE) {
		ret = -EINVAL;
		goto out;
	}

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241107181531.1774550-1-andreas@kemnade.info/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches