linux-kernel - Re: [PATCH] wifi: mwifiex: decrease timeout waiting for host sleep from 10s to 5s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173375999181.157598.15598577464504869106.kvalo@kernel.org>
Date: Mon,  9 Dec 2024 15:59:53 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Pin-yen Lin <treapking@...omium.org>
Cc: Francesco Dolcini <francesco@...cini.it>, David Lin <yu-hao.lin@....com>,
 Pin-yen Lin <treapking@...omium.org>, Doug Anderson <dianders@...omium.org>,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: decrease timeout waiting for host sleep
 from
 10s to 5s

Pin-yen Lin <treapking@...omium.org> wrote:

> In commit 52250cbee7f6 ("mwifiex: use timeout variant for
> wait_event_interruptible") it was noted that sometimes we seemed
> to miss the signal that our host sleep settings took effect. A
> 10 second timeout was added to the code to make sure we didn't
> hang forever waiting. It appears that this problem still exists
> and we hit the timeout sometimes for Chromebooks in the field.
> 
> Recently on ChromeOS we've started setting the DPM watchdog
> to trip if full system suspend takes over 10 seconds. Given
> the timeout in the original patch, obviously we're hitting
> the DPM watchdog before mwifiex gets a chance to timeout.
> 
> While we could increase the DPM watchdog in ChromeOS to avoid
> this problem, it's probably better to simply decrease the
> timeout. Any time we're waiting several seconds for the
> firmware to respond it's likely that the firmware won't ever
> respond. With that in mind, decrease the timeout in mwifiex
> from 10 seconds to 5 seconds.
> 
> Suggested-by: Doug Anderson <dianders@...omium.org>
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Acked-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless-next.git, thanks.

f143cece43dd wifi: mwifiex: decrease timeout waiting for host sleep from 10s to 5s

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241127105709.4014302-1-treapking@chromium.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches