linux-kernel - drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c:79 devm_imx_drm_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412080122.CgaCjXX5-lkp@intel.com>
Date: Mon, 9 Dec 2024 12:28:26 +0800
From: kernel test robot <lkp@...el.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c:79
 devm_imx_drm_legacy_bridge() warn: inconsistent indenting

Hi Dmitry,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b5f217084ab3ddd4bdd03cd437f8e3b7e2d1f5b6
commit: 4c3d525f65733e760f3700c0f3c83e8e46d2dcd8 drm/imx: ldb: switch to imx_legacy_bridge / drm_bridge_connector
date:   3 months ago
config: nios2-randconfig-r073-20241206 (https://download.01.org/0day-ci/archive/20241208/202412080122.CgaCjXX5-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412080122.CgaCjXX5-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c:79 devm_imx_drm_legacy_bridge() warn: inconsistent indenting

vim +79 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c

cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  53  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  54  struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  55  					      struct device_node *np,
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  56  					      int type)
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  57  {
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  58  	struct imx_legacy_bridge *imx_bridge;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  59  	int ret;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  60  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  61  	imx_bridge = devm_kzalloc(dev, sizeof(*imx_bridge), GFP_KERNEL);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  62  	if (!imx_bridge)
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  63  		return ERR_PTR(-ENOMEM);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  64  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  65  	ret = of_get_drm_display_mode(np,
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  66  				      &imx_bridge->mode,
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  67  				      &imx_bridge->bus_flags,
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  68  				      OF_USE_NATIVE_MODE);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  69  	if (ret)
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  70  		return ERR_PTR(ret);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  71  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  72  	imx_bridge->mode.type |= DRM_MODE_TYPE_DRIVER;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  73  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  74  	imx_bridge->base.funcs = &imx_legacy_bridge_funcs;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  75  	imx_bridge->base.of_node = np;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  76  	imx_bridge->base.ops = DRM_BRIDGE_OP_MODES;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  77  	imx_bridge->base.type = type;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  78  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02 @79         ret = devm_drm_bridge_add(dev, &imx_bridge->base);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  80         if (ret)
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  81                 return ERR_PTR(ret);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  82  
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  83  	return &imx_bridge->base;
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  84  }
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  85  EXPORT_SYMBOL_GPL(devm_imx_drm_legacy_bridge);
cc3e8a216d6b817 Dmitry Baryshkov 2024-06-02  86  

:::::: The code at line 79 was first introduced by commit
:::::: cc3e8a216d6b817c509e1e1a3700055d178e04f8 drm/imx: add internal bridge handling display-timings DT node

:::::: TO: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
:::::: CC: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki