linux-kernel - Re: [PATCH v1] firewire: ohci: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241209162503.GA3198764@bhelgaas>
Date: Mon, 9 Dec 2024 10:25:03 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Vaibhav Gupta <vaibhavgupta40@...il.com>,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] firewire: ohci: use generic power management

On Sat, Dec 07, 2024 at 10:13:16AM +0900, Takashi Sakamoto wrote:
> On Mon, Jul 20, 2020 at 08:37:16PM +0530, Vaibhav Gupta wrote:
> > Drivers using legacy PM have to manage PCI states and device's PM states
> > themselves. They also need to take care of configuration registers.
> > 
> > With improved and powerful support of generic PM, PCI Core takes care of
> > above mentioned, device-independent, jobs.
> > 
> > This driver makes use of PCI helper functions like
> > pci_save/restore_state(), pci_disable_device() and pci_set_power_state() to
> > do required operations. In generic mode, they are no longer needed.
> > 
> > Change function parameter in both .suspend() and .resume() to
> > "struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable.
> > 
> > Compile-tested only.
> > 
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
> > ---
> >  drivers/firewire/ohci.c | 43 ++++++++++++-----------------------------
> >  1 file changed, 12 insertions(+), 31 deletions(-)
> 
> Although it takes a long time since the patch was posted, I applied it
> now to for-next branch with my handy changes to optimize to v6.13-rc1. 

Great!  Thanks very much for rescuing this patch!  We still have a
couple stragglers, but we may yet be able to retire the legacy PCI
power management.

> I still have a slight concern about the operation specific to powermac
> platforms, however let us fix when receiving any reports from the users.

Please let us know if/when you see any reports, and we'll be happy to
help fix them.

Bjorn