linux-kernel - Re: [PATCH v11 0/8] x86/resctrl: mba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5f5b3ff-27ac-41c1-ac5a-858eb82d607d@amd.com>
Date: Mon, 9 Dec 2024 13:15:25 -0600
From: "Moger, Babu" <babu.moger@....com>
To: Borislav Petkov <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>
Cc: "Chatre, Reinette" <reinette.chatre@...el.com>,
 "Yu, Fenghua" <fenghua.yu@...el.com>, Peter Newman <peternewman@...gle.com>,
 Jonathan Corbet <corbet@....net>, "x86@...nel.org" <x86@...nel.org>,
 James Morse <james.morse@....com>, Jamie Iles <quic_jiles@...cinc.com>,
 Randy Dunlap <rdunlap@...radead.org>,
 "Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: Re: [PATCH v11 0/8] x86/resctrl: mba_MBps enhancement



On 12/9/24 11:57, Borislav Petkov wrote:
> On Mon, Dec 09, 2024 at 05:53:12PM +0000, Luck, Tony wrote:
>> v6.13-rc1 may give a lockdep splat when mounting /sys/fs/resctrl
>> (known CONFIG options to trigger this are:
>>
>> 	PROVE_LOCKING && SELINUX && (EXT4 || BTRFS)
>>
>> but there may be others).
>>
>> These resctrl patches are not directly dependent on the fixes that
>> went into -rc2:
>>
>>    22465bbac53c blk-mq: move cpuhp callback registering out of q->sysfs_lock
>>    4bf485a7db5d blk-mq: register cpuhp callback after hctx is added to xarray table
>>
>> they work ok on top of -rc1  (as long as you ignore the lockdep splat).
> 
> Thanks for the details.
> 
>> I see you already have one patch in TIP x86/cache on top of v6.13-rc1
>>
>> Your choice whether to rebase that to -rc2 and then apply my series. It
>> might make testing smoother.
> 
> Yah, I can rebase. Not worth the hassle of dealing with bogus reports.
> 

Sanity tested on AMD system. Changes look good.

Tested-by: Babu Moger <babu.moger@....com>

-- 
Thanks
Babu Moger