linux-kernel - Re: [PATCH v1] perf jevents: Fix build issue in '*/' in event descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUze9j8etq-17L0dWVoYfE-bA+61wrEAXN9vJSCj9dCbw@mail.gmail.com>
Date: Mon, 9 Dec 2024 13:29:15 -0800
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	John Garry <john.g.garry@...cle.com>, Sandipan Das <sandipan.das@....com>, 
	Xu Yang <xu.yang_2@....com>, Benjamin Gray <bgray@...ux.ibm.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf jevents: Fix build issue in '*/' in event descriptions

On Mon, Dec 9, 2024 at 12:28 PM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> On Mon, Dec 09, 2024 at 10:35:34AM -0800, Ian Rogers wrote:
> > On Wed, Nov 13, 2024 at 8:56 AM Ian Rogers <irogers@...gle.com> wrote:
> > >
> > > For big string offsets we output comments for what string the offset
> > > is for. If the string contains a '*/' as seen in Intel Arrowlake event
> > > descriptions, then this causes C parsing issues for the generated
> > > pmu-events.c. Catch such '*/' values and escape to avoid this.
> > >
> > > Signed-off-by: Ian Rogers <irogers@...gle.com>
> >
> > Ping.
>
> A fixes: is missing, probably this should go via perf-tools, i.e. for
> this merge window?

We don't yet have arrowlake events/metrics, should there be a fixes?
I'm just preparing the patches for the latest vendor json from Intel,
but they will depend on this. I suspect given the size of the vendor
json it will miss the current merge window.

Thanks,
Ian