linux-kernel - Re: [PATCH v3 1/5] hyperv: Move hv_connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1Y0uJlVn-86KHE8@liuwe-devbox-debian-v2>
Date: Mon, 9 Dec 2024 00:07:20 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	iommu@...ts.linux.dev, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-arch@...r.kernel.org,
	virtualization@...ts.linux.dev, kys@...rosoft.com,
	haiyangz@...rosoft.com, wei.liu@...nel.org, mhklinux@...look.com,
	decui@...rosoft.com, catalin.marinas@....com, will@...nel.org,
	luto@...nel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	seanjc@...gle.com, pbonzini@...hat.com, peterz@...radead.org,
	daniel.lezcano@...aro.org, joro@...tes.org, robin.murphy@....com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, lpieralisi@...nel.org, kw@...ux.com,
	robh@...nel.org, bhelgaas@...gle.com, arnd@...db.de,
	sgarzare@...hat.com, jinankjain@...ux.microsoft.com,
	muminulrussell@...il.com, skinsburskii@...ux.microsoft.com,
	mukeshrathor@...rosoft.com, vkuznets@...hat.com,
	ssengar@...ux.microsoft.com, apais@...ux.microsoft.com,
	eahariha@...ux.microsoft.com, horms@...nel.org
Subject: Re: [PATCH v3 1/5] hyperv: Move hv_connection_id to hyperv-tlfs.h

On Mon, Nov 25, 2024 at 03:24:40PM -0800, Nuno Das Neves wrote:
> This definition is in the wrong file; it is part of the TLFS doc.
> 
> Acked-by: Wei Liu <wei.liu@...nel.org>
> Reviewed-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> Reviewed-by: Michael Kelley <mhklinux@...look.com>
> Signed-off-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>

One comment about the ordering of the tags. It is better to organize
them in the following order:

Signed-off-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Acked-by: Wei Liu <wei.liu@...nel.org>
Reviewed-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
Reviewed-by: Michael Kelley <mhklinux@...look.com>

I've made the change for you while applying the patch.

Thanks,
Wei.