linux-kernel - Re: drivers/staging/gpib/common/gpib_os.c:871 ibioctl() warn: inconsistent returns '&board->big_gpib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d19c29ac-a084-4feb-a272-5ae6361732db@stanley.mountain>
Date: Mon, 9 Dec 2024 12:08:31 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Dave Penkler <dpenkler@...il.com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: drivers/staging/gpib/common/gpib_os.c:871 ibioctl() warn:
 inconsistent returns '&board->big_gpib_mutex'.

On Mon, Dec 09, 2024 at 09:50:15AM +0300, Dan Carpenter wrote:
> 9dde4559e93955 Dave Penkler 2024-09-18  757  	switch (cmd) {
> 9dde4559e93955 Dave Penkler 2024-09-18  758  	case IBEVENT:
> 9dde4559e93955 Dave Penkler 2024-09-18  759  		retval = event_ioctl(board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18  760  		goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18  761  	case IBCLOSEDEV:
> 9dde4559e93955 Dave Penkler 2024-09-18  762  		retval = close_dev_ioctl(filep, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18  763  		goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18  764  	case IBOPENDEV:
> 9dde4559e93955 Dave Penkler 2024-09-18  765  		retval = open_dev_ioctl(filep, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18  766  		goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18  767  	case IBSPOLL_BYTES:
> 9dde4559e93955 Dave Penkler 2024-09-18  768  		retval = status_bytes_ioctl(board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18  769  		goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18  770  	case IBWAIT:
> 9dde4559e93955 Dave Penkler 2024-09-18  771  		retval = wait_ioctl(file_priv, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18  772  		if (retval == -ERESTARTSYS)
> 9dde4559e93955 Dave Penkler 2024-09-18  773  			return retval;
> 
> mutex_unlock(&board->big_gpib_mutex) before returning.
> 

Sorry, this is a false positive.  The kbuild-bot can't use cross function
analysis because it doesn't scale.  But if you had cross function analysis
enabled then it wouldn't have printed this false positive.

regards,
dan carpenter