linux-kernel - Re: [PATCH v2 1/4] dt-bindings: input: touchscreen: edt-ft5x06: add panel property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <psgcnoeyutfkebbi2aavqrcsdqslfu74gmchc4csvkzssniqua@i4n5x6rpdhtr>
Date: Mon, 9 Dec 2024 10:23:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joel Selvaraj <joelselvaraj.oss@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, 
	Joel Selvaraj <foss@...lselvaraj.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: input: touchscreen: edt-ft5x06: add
 panel property

On Sun, Dec 08, 2024 at 09:23:27AM -0600, Joel Selvaraj wrote:
> In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech
> FT8719 touchscreen is integrally connected to the display panel
> (EBBG FT8719) and thus should be power sequenced together with display
> panel for proper functioning. Add the panel property which optionally
> allows to link panel to the touchscreen.
> 
> Signed-off-by: Joel Selvaraj <foss@...lselvaraj.com>

SoB mismatch.

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> index 70a922e213f2a..35a6ac4ded7c7 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> @@ -103,6 +103,7 @@ properties:
>      minimum: 0
>      maximum: 255
>  
> +  panel: true

So you just list all properties from touchscreen... no, use
unevaluatedProperties instead of additionalProperties.

Best regards,
Krzysztof