linux-kernel - Re: [GIT PULL] Devicetree updates for v6.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241209092809.GA3246424@google.com>
Date: Mon, 9 Dec 2024 17:28:09 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Rob Herring <robh@...nel.org>
Cc: Sasha Levin <sashal@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [GIT PULL] Devicetree updates for v6.13

On Mon, Nov 25, 2024 at 09:15:56AM -0600, Rob Herring wrote:
> On Mon, Nov 25, 2024 at 7:24 AM Sasha Levin <sashal@...nel.org> wrote:
> >
> > On Mon, Nov 25, 2024 at 12:33:48PM +0100, Krzysztof Kozlowski wrote:
> > >On 25/11/2024 12:00, Krzysztof Kozlowski wrote:
> > >> On 25/11/2024 11:34, Chen-Yu Tsai wrote:
> > >>> On Mon, Nov 25, 2024 at 5:48 PM AngeloGioacchino Del Regno
> > >>> <angelogioacchino.delregno@...labora.com> wrote:
> > >>>>
> > >>>> Il 24/11/24 17:59, Sasha Levin ha scritto:
> > >>>>> On Sun, Nov 24, 2024 at 05:47:33PM +0100, Krzysztof Kozlowski wrote:
> > >>>>>> On 24/11/2024 17:29, Sasha Levin wrote:
> > >>>>>>> Hi Rob,
> > >>>>>>>
> > >>>>>>> On Mon, Nov 18, 2024 at 03:07:30PM -0600, Rob Herring wrote:
> > >>>>>>>>      of: WARN on deprecated #address-cells/#size-cells handling
> > >>>>>>>
> > >>>>>>> With the commit above, I've started seeing boot warnings on a few
> > >>>>>>
> > >>>>>> And same boards do not report problems on the next?
> > >>>>>
> > >>>>> Looks like they do. I haven't checked it previously, but I see that we
> > >>>>> have similar warnings on a few boards that KernelCI is testing -next on.
> > >>>>>
> > >>>>
> > >>>> That's... horrendous.
> > >>>>
> > >>>> I hope that we can get a proper fix with a bootloader update on these (now very
> > >>>> old) devices... Adding a Google engineer to the loop so that he can follow up
> > >>>> internally.
> > >>>
> > >>> AFAIK that's unlikely going to happen given the resources needed from
> > >>> the ODMs for a firmware re-qualification. Or we would have fixed the GIC
> > >>> bug in ATF and had pseudo-NMI.
> > >>>
> > >>> Some of the firmware code involved is 10 years old, so even the RK3399
> > >>> Chromebooks, which no longer have support, could suffer from this as
> > >>> well.
> > >>>
> > >>>> The alternative would be to hack-in a firmware node to mt8183-kukui.dtsi, but....
> > >>>> ...ugh. That'd be indeed a hack for the sole purpose of fixing a bootloader that
> > >>>> is acting in a broken way, and I don't like that at all (...and I'm sure I'm not
> > >>>> alone!).
> > >>>
> > >>
> > >> Then we should add it to the exception list. Let me take a look at this.
> > >https://lore.kernel.org/linux-devicetree/20241125113151.107812-1-krzysztof.kozlowski@linaro.org/T/#u
> > >
> > >I sent a fix for this platform only. You did not paste links to other
> > >failing platforms (and sorry but kernelci web interface was absolutely
> > >unmanageable and unusable, so I am not going to even try to look for
> > >them) so not sure who should be added to list of exceptions.
> >
> > The new dashboard isn't *that* bad :)
> 
> You are reporting this issue because it is that bad. I tested this on
> KCI before this even went to next. I gave up trying to get boot logs
> out from all the boards. Though which boards run seems to be a crap
> shoot, but that's not a dashboard problem.
> 
> >
> > A list of platforms that show this issue:
> >
> > - google,spherion-rev3 | google,spherion-rev2
> > - google,steelix-sku131072 | google,steelix
> > - google,tomato-rev2 | google,tomato | mediatek,mt8195
> > - google,juniper-sku16 | google,juniper | mediatek,mt8183
> > - google,kingoftown | qcom,sc7180
> > - google,lazor-rev5-sku5 | google,lazor-rev5-sku6
> 
> Can I get a dump of the DTB for one of these boards? The upstream dts
> files don't seem to have a /firmware node.

Attached two files. These were copied from /sys/firmware/fdt.

- juniper.dtb - google,juniper-sku16 | google,juniper | mediatek,mt8183
- steelix.dtb - google,steelix-sku131072 | google,steelix | mediatek,mt8186

juniper.dtb is the upstream dts plus some changes I need to get the
external display to work, plus whatever the *existing* firmware inserts.

steelix.dtb is the same, plus the firmware now inserts #address-cells
and #size-cells under /firmware. This fix has landed for all future
ChromeOS devices via our main firmware branch [1].

AFAIK they also have a bad FDT END symbol. This was only recently
discovered and fixed for future devices [2].


ChenYu

[1] Gerrit: https://crrev.com/c/6051580
[2] Gerrit: https://review.coreboot.org/c/coreboot/+/85462

Download attachment "juniper.dtb" of type "application/octet-stream" (88207 bytes)

Download attachment "steelix.dtb" of type "application/octet-stream" (98078 bytes)