linux-kernel - Re: [PATCH] dt-bindings: mmc: atmel,hsmci: Convert to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc15c9de-4cf8-44e3-976a-936bf16b7ab2@microchip.com>
Date: Mon, 9 Dec 2024 02:37:37 +0000
From: <Dharma.B@...rochip.com>
To: <conor@...nel.org>
CC: <ulf.hansson@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>,
	<alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
	<Aubin.Constans@...rochip.com>, <linux-mmc@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: mmc: atmel,hsmci: Convert to json schema

On 06/12/24 10:32 pm, Conor Dooley wrote:
> 
> On Fri, Dec 06, 2024 at 05:16:39AM +0000,Dharma.B@...rochip.com wrote:
>> Hi Conor,
>>
>> On 05/12/24 11:15 pm, Conor Dooley wrote:
>>> On Thu, Dec 05, 2024 at 03:27:02PM +0530, Dharma Balasubiramani wrote:
>>>
>>>> +patternProperties:
>>>> +  "^slot@[0-9]+$":
>>>> +    type: object
>>>> +    description: A slot node representing an MMC, SD, or SDIO slot.
>>>> +
>>>> +    allOf:
>>>> +      - $ref: mmc-controller.yaml
>>>> +
>>>> +    properties:
>>>> +      reg:
>>>> +        description: Slot ID.
>>>> +        minimum: 0
>>>> +
>>>> +      bus-width:
>>>> +        description: Number of data lines connected to the controller.
>>>> +        enum: [1, 4, 8]
>>>> +
>>>> +      cd-gpios:
>>>> +        description: GPIO used for card detection.
>>>> +
>>>> +      cd-inverted:
>>>> +        type: boolean
>>> This type conflicts with mmc-controller.yaml, it's a flag there.
>> Yes, I overlooked it. I'll simply remove the type here.
>>
>>>> +        description: Inverts the value of the card detection GPIO.
>>>> +
>>>> +      wp-gpios:
>>>> +        description: GPIO used for write protection.
>>>> +
>>>> +    required:
>>>> +      - reg
>>>> +      - bus-width
>>>> +
>>>> +    unevaluatedProperties: false
>>> Do you mean additionalProperties: false here? You listed properties
>>> contained in mmc-controller.yaml which makes it seem like you're
>>> restricting to this subset rather than allowing all properties - but you
>>> need additionalProperties: false to do that.
>> No, I'm not restricting the properties to this subset. There are
>> additional properties, such as "non-removable," "broken-cd," and
>> "disable-wp," that are used in our DTS files but are not defined in the
>> old text bindings. For this reason, I used `unevaluatedProperties:
>> false` instead of `additionalProperties: false`.
>> Let me know if an
>> `allOf` reference to `mmc-controller` alone would be sufficient in this
>> context.
> Yes, there's no point duplicating properties from there, unless you're
> restricting to a subset. I think all you need to keep (other than the
> reference) is the required properties list because there seems to be
> none in mmc-controller.yaml.

Sure, I will update the binding and will send a v2.
Thanks.

-- 
With Best Regards,
Dharma B.