linux-kernel - Re: [PATCH v2 3/6] mmc: sdhci-acpi: Remove not so useful error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69ad297e-f5d9-4b78-95f6-f3701b6b12d0@intel.com>
Date: Mon, 9 Dec 2024 13:05:31 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Victor Shih <victor.shih@...esyslogic.com.tw>, linux-mmc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] mmc: sdhci-acpi: Remove not so useful error
 message

On 1/11/24 12:11, Andy Shevchenko wrote:
> First of all, this error message is just informative and doesn't prevent
> driver from going on. Second, the ioremap() on many architectures just
> works on page size granularity, which is higher than 256 bytes. Last,
> but not lease, this is an impediment for furhter cleanups, hence remove

lease -> least
furhter -> further

> it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-acpi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 5241c5c26891..f861e9a3a911 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -849,9 +849,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	len = resource_size(iomem);
> -	if (len < 0x100)
> -		dev_err(dev, "Invalid iomem size!\n");
> -
>  	if (!devm_request_mem_region(dev, iomem->start, len, dev_name(dev)))
>  		return -ENOMEM;
>