linux-kernel - Re: [PATCH v2] sched: deadline: Cleanup goto label in pick_earliest_pushable_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1bYFEJF5lezddFe@jlelli-thinkpadt14gen4.remote.csb>
Date: Mon, 9 Dec 2024 11:44:20 +0000
From: Juri Lelli <juri.lelli@...hat.com>
To: John Stultz <jstultz@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Wanpeng Li <wanpeng.li@...ux.intel.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Todd Kjos <tkjos@...gle.com>, kernel-team@...roid.com
Subject: Re: [PATCH v2] sched: deadline: Cleanup goto label in
 pick_earliest_pushable_dl_task

Hi John,

On 05/12/24 15:59, John Stultz wrote:
> Commit 8b5e770ed7c0 ("sched/deadline: Optimize pull_dl_task()")
> added a goto label seems would be better written as a while
> loop.
> 
> So replace the goto with a while loop, to make it easier to read.
> 
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Juri Lelli <juri.lelli@...hat.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Ben Segall <bsegall@...gle.com>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Wanpeng Li <wanpeng.li@...ux.intel.com>
> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Cc: Todd Kjos <tkjos@...gle.com>
> Cc: kernel-team@...roid.com
> Reported-by: Todd Kjos <tkjos@...gle.com>
> Signed-off-by: John Stultz <jstultz@...gle.com>

Acked-by: Juri Lelli <juri.lelli@...hat.com>

Thanks!
Juri