linux-kernel - Re: [PATCH] rust: macros: add authors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241209125520.414960-1-trintaeoitogc@gmail.com>
Date: Mon,  9 Dec 2024 09:55:20 -0300
From: guilherme giacomo simoes <trintaeoitogc@...il.com>
To: miguel.ojeda.sandonis@...il.com
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	daniel@...lak.dev,
	fujita.tomonori@...il.com,
	gary@...yguo.net,
	linux-kernel@...r.kernel.org,
	ojeda@...nel.org,
	rust-for-linux@...r.kernel.org,
	tahbertschinger@...il.com,
	tmgross@...ch.edu,
	trintaeoitogc@...il.com,
	walmeida@...rosoft.com,
	wcampbell1995@...il.com
Subject: Re: [PATCH] rust: macros: add authors

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
> Yeah, that is a good point. There are hundreds of drivers with 2+
> authors, so this could indeed be an issue eventually.
> 
> Having said that, we already have e.g. the `alias` and `firmware` keys
> that take a list, so I think we already have the potential issue, thus
> being consistent in our use of lists sounds simpler (unless we are
> discussing migrating those away too).
> 
> We could also try to mitigate the formatting issue via e.g.
> `checkpatch.pl` if needed.
It is true, we already have the formatting problem with `alias` and `firmware`
fields.
If we will follow this logic (doing equal in C side repeating fields), maybe we
can end have the lines a lot for modules that have a `alias` a lot, or
`firmaware` a lot. Two example about this is the `sound/oao/fabrics/layout.c`
that have the 38 MODULE_ALIAS and `drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c` that
have 77 MODULE_FIRMWARE.

Maybe, have something like:
	authors: ["author", "author", "author", "author", 
		"author", "author", "author", "author", "author"]

and having a check on checkpath.pl doesn't seem like a bad idea. Because for me
it's better than:

	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author"

due to the fact that we spend more time scrolling the screen code than
programming.

But I don't sure. 

Thanks and regards,
Guilherme