linux-kernel - Re: [PATCH] spi: zynq-qspi: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9de6025d-2173-4b50-aa55-65a6a89d995b@sirena.org.uk>
Date: Mon, 9 Dec 2024 13:03:53 +0000
From: Mark Brown <broonie@...nel.org>
To: Mingwei Zheng <zmw12306@...il.com>
Cc: michal.simek@....com, linus.walleij@...aro.org,
	linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH] spi: zynq-qspi: Add check for clk_enable()

On Fri, Dec 06, 2024 at 08:32:58PM -0500, Mingwei Zheng wrote:

> -	clk_enable(qspi->refclk);
> -	clk_enable(qspi->pclk);
> +	ret = clk_enable(qspi->refclk);
> +	if (ret)
> +		return ret;
> +
> +	ret = clk_enable(qspi->pclk);
> +	if (ret)
> +		return ret;

The second check leaks the first enable.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)