linux-kernel - Re: [PATCH v2] drivers: media: imx296: Add standby delay during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1hDpzB6LOZYH8vA@valkosipuli.retiisi.eu>
Date: Tue, 10 Dec 2024 13:35:35 +0000
From: Sakari Ailus <sakari.ailus@....fi>
To: Alexandru Ardelean <aardelean@...libre.com>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	laurent.pinchart@...asonboard.com, manivannan.sadhasivam@...aro.org,
	sakari.ailus@...ux.intel.com, mchehab@...nel.org,
	kieran.bingham@...asonboard.com, naush@...pberrypi.com
Subject: Re: [PATCH v2] drivers: media: imx296: Add standby delay during probe

Hi Alexandru,

On Fri, Nov 15, 2024 at 08:07:17PM +0200, Alexandru Ardelean wrote:
> From: Naushir Patuck <naush@...pberrypi.com>
> 
> Add a 2-5ms delay when coming out of standby and before reading the
> sensor info register durning probe, as instructed by the datasheet. This
> standby delay is already present when the sensor starts streaming.
> 
> During a cold-boot, reading the IMX296_SENSOR_INFO register would often
> return a value of 0x0000, if this delay is not present before.
> 
> Fixes: cb33db2b6ccfe ("media: i2c: IMX296 camera sensor driver")
> Tested-by: Alexandru Ardelean <aardelean@...libre.com>
> Signed-off-by: Naushir Patuck <naush@...pberrypi.com>

Thanks for the patch.

You always need to Cc: stable if you have a Fixes: tag nowadays. I'll add
it this time.

-- 
Sakari Ailus