[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPDyKFpWfqpgmMpuq+69ee2FU7wOSgHUmfEcLpS1Dy2vx8c-MA@mail.gmail.com>
Date: Tue, 10 Dec 2024 15:02:01 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-pm@...r.kernel.org, aford173@...il.com,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 2/2] pmdomain: gpcv2: Suppress bind attrs
On Fri, 6 Dec 2024 at 12:28, Peng Fan (OSS) <peng.fan@....nxp.com> wrote:
>
> From: Peng Fan <peng.fan@....com>
>
> The gpcv2 drivers on imx8m series are registered as platform
> devices and this opens the possibility of reloading the driver
> at runtime.
>
> But this doesn't actually work. There are some hardware sequence
> dependecy between blk ctrl and gpc, also power domains are used
> by other peripherals, so fix this by explicitly suppressing bind
> attrs.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/imx/gpcv2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pmdomain/imx/gpcv2.c b/drivers/pmdomain/imx/gpcv2.c
> index e67ecf99ef84..4db4d666f5bf 100644
> --- a/drivers/pmdomain/imx/gpcv2.c
> +++ b/drivers/pmdomain/imx/gpcv2.c
> @@ -1437,6 +1437,7 @@ static struct platform_driver imx_pgc_domain_driver = {
> .driver = {
> .name = "imx-pgc",
> .pm = &imx_pgc_domain_pm_ops,
> + .suppress_bind_attrs = true,
> },
> .probe = imx_pgc_domain_probe,
> .remove = imx_pgc_domain_remove,
> @@ -1549,6 +1550,7 @@ static struct platform_driver imx_gpc_driver = {
> .driver = {
> .name = "imx-gpcv2",
> .of_match_table = imx_gpcv2_dt_ids,
> + .suppress_bind_attrs = true,
> },
> .probe = imx_gpcv2_probe,
> };
> --
> 2.37.1
>
Powered by blists - more mailing lists