linux-kernel - Re: [PATCH v10 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGs72rxvguSYbALWPL2FrO5coyijQXY4HEQdwvr8Fj4XKQ@mail.gmail.com>
Date: Tue, 10 Dec 2024 06:30:44 -0800
From: Rob Clark <robdclark@...il.com>
To: Will Deacon <will@...nel.org>
Cc: iommu@...ts.linux.dev, linux-arm-msm@...r.kernel.org, 
	freedreno@...ts.freedesktop.org, Robin Murphy <robin.murphy@....com>, 
	Mostafa Saleh <smostafa@...gle.com>, Rob Clark <robdclark@...omium.org>, 
	Boris Brezillon <boris.brezillon@...labora.com>, 
	"open list:DRM DRIVER for Qualcomm Adreno GPUs" <dri-devel@...ts.freedesktop.org>, Jason Gunthorpe <jgg@...pe.ca>, 
	Joao Martins <joao.m.martins@...cle.com>, Joerg Roedel <jroedel@...e.de>, 
	Konrad Dybcio <konradybcio@...nel.org>, 
	"moderated list:ARM SMMU DRIVERS" <linux-arm-kernel@...ts.infradead.org>, 
	open list <linux-kernel@...r.kernel.org>, 
	"open list:POWER MANAGEMENT CORE" <linux-pm@...r.kernel.org>, Marijn Suijten <marijn.suijten@...ainline.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Sean Paul <sean@...rly.run>, Steven Price <steven.price@....com>
Subject: Re: [PATCH v10 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

On Tue, Dec 10, 2024 at 3:14 AM Will Deacon <will@...nel.org> wrote:
>
> Hi Rob,
>
> On Mon, Oct 28, 2024 at 02:31:36PM -0700, Rob Clark wrote:
> > From: Rob Clark <robdclark@...omium.org>
> >
> > This series extends io-pgtable-arm with a method to retrieve the page
> > table entries traversed in the process of address translation, and then
> > beefs up drm/msm gpu devcore dump to include this (and additional info)
> > in the devcore dump.
> >
> > This is a respin of https://patchwork.freedesktop.org/series/94968/
> > (minus a patch that was already merged)
> >
> > v2:  Fix an armv7/32b build error in the last patch
> > v3:  Incorperate Will Deacon's suggestion to make the interface
> >      callback based.
> > v4:  Actually wire up the callback
> > v5:  Drop the callback approach
> > v6:  Make walk-data struct pgtable specific and rename
> >      io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data
> > v7:  Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty()
> > v8:  Pass pte pointer to callback so it can modify the actual pte
> > v9:  Fix selftests_running case
> > v10: Call visit cb for all nodes traversed, leave the decision about
> >      whether to care about non-leaf nodes to the callback
>
> Do you plan to respin this? I see Mostafa left a proposal on patch 3.

Yeah, his suggestion looked reasonable.  I'll try to get back to this
patchset today.

BR,
-R