linux-kernel - Re: [PATCH v2 14/15] arm64: dts: renesas: r9a08g045: Add USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXxo1YShE1MNTPDvmZKSYv_YvUvO3yaFM4ypdmSfF00uw@mail.gmail.com>
Date: Tue, 10 Dec 2024 16:38:24 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, p.zabel@...gutronix.de, geert+renesas@...der.be, 
	magnus.damm@...il.com, gregkh@...uxfoundation.org, 
	yoshihiro.shimoda.uh@...esas.com, christophe.jaillet@...adoo.fr, 
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-usb@...r.kernel.org, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v2 14/15] arm64: dts: renesas: r9a08g045: Add USB support

Hi Claudiu,

On Tue, Nov 26, 2024 at 10:21 AM Claudiu <claudiu.beznea@...on.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Add USB nodes for the Renesas RZ/G3S SoC. This consists of PHY reset,
> host and device support.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> ---
>
> Changes in v2:
> - this was patch 14/16 in v1
> - added renesas,sysc-signal properties to USB PHYs
> - collected tags
> - Geert: I kept your tag; please let me know if you consider otherwise

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> @@ -417,6 +417,125 @@ eth1: ethernet@...40000 {
>                         status = "disabled";
>                 };
>
> +               phyrst: usbphy-ctrl@...00000 {
[...]
> +               ohci0: usb@...10000 {
[...]
> +               ehci0: usb@...10100 {
[...]
> +               usb2_phy0: usb-phy@...10200 {
[...]
> +               hsusb: usb@...20000 {
[...]
> +               ohci1: usb@...30000 {
[...]
> +               ehci1: usb@...30100 {
[...]
> +               usb2_phy1: usb-phy@...30200 {

Please keep similar nodes together, i.e.

    phyrst: usbphy-ctrl@...00000 {
    ohci0: usb@...10000 {
    ohci1: usb@...30000 {
    ehci0: usb@...10100 {
    ehci1: usb@...30100 {
    usb2_phy0: usb-phy@...10200 {
    usb2_phy1: usb-phy@...30200 {
    hsusb: usb@...20000 {

After that, you can easily compare with similar SoCs:

    soc-dts-diff arch/arm64/boot/dts/renesas/r9a0{7g044,8g045}.dtsi

https://github.com/geertu/linux-scripts/blob/master/soc-dts-diff

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds