linux-kernel - Re: [PATCH AUTOSEL 6.12 033/107] accel/qaic: Add AIC080 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1hpX_BduAF4b54s@sashalap>
Date: Tue, 10 Dec 2024 11:16:31 -0500
From: Sasha Levin <sashal@...nel.org>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Troy Hanson <quic_thanson@...cinc.com>,
	Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
	ogabbay@...nel.org, corbet@....net, linux-arm-msm@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.12 033/107] accel/qaic: Add AIC080 support

On Sun, Nov 24, 2024 at 12:07:20PM -0700, Jeffrey Hugo wrote:
>On 11/24/2024 6:28 AM, Sasha Levin wrote:
>>From: Jeffrey Hugo <quic_jhugo@...cinc.com>
>>
>>[ Upstream commit b8128f7815ff135f0333c1b46dcdf1543c41b860 ]
>>
>>Add basic support for the new AIC080 product. The PCIe Device ID is
>>0xa080. AIC080 is a lower cost, lower performance SKU variant of AIC100.
>> From the qaic perspective, it is the same as AIC100.
>>
>>Reviewed-by: Troy Hanson <quic_thanson@...cinc.com>
>>Signed-off-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
>>Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
>>Link: https://patchwork.freedesktop.org/patch/msgid/20241004195209.3910996-1-quic_jhugo@quicinc.com
>>Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>Sasha, it feels like autosel was a bit aggressive here.  This is an 
>enablement patch for new hardware, and not a bug fix.  Therefore, it 
>does not appear to be stable material to me.
>
>Am I missing something?

Yup, we also take patches that enable new hardware by adding PCI/USB/etc
IDs as well as quirks.

-- 
Thanks,
Sasha