linux-kernel - Re: dm: Allow the use of escaped characters in str_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1hrfMRedzEJb26O@kernel.org>
Date: Tue, 10 Dec 2024 11:25:32 -0500
From: Mike Snitzer <snitzer@...nel.org>
To: Mikulas Patocka <mpatocka@...hat.com>, zkabelac@...hat.com
Cc: Mohammed Anees <pvmohammedanees2003@...il.com>,
	Alasdair Kergon <agk@...hat.com>, dm-devel@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: dm: Allow the use of escaped characters in str_field_delimit()

On Mon, Nov 18, 2024 at 11:38:05AM +0100, Mikulas Patocka wrote:
> 
> 
> On Tue, 12 Nov 2024, Mohammed Anees wrote:
> 
> > Escape characters were not handled before, which could lead to
> > unwanted issues. Some device-mapper names may contain backslashes (`\`)
> > as valid characters and should not be treated as escape characters. Only
> > escape characters followed directly by the separator are considered
> > valid and need to be processed. After handling, the escape characters
> > are removed to ensure the final string is correctly parsed without
> > unwanted escape sequences which were used only for escaping.
> > 
> > Signed-off-by: Mohammed Anees <pvmohammedanees2003@...il.com>
> 
> Hi
> 
> Does anyone really need this? Is there some use case for using escape 
> characters in device mapper names?

It would seem Mohammed cared enough to write the patch, but not reply
to you with further clarification on why it needed...

BUT, in this instance it follows that: if lvm2 is allowing weird names
which require escacped characters _and_ dm-init is used then dm-init
needs to support handling them (dm-init is all about _not_ using
normal initramfs with lvm2 in all its glory).

Mike