linux-kernel - Re: [PATCH net-next v1 09/11] net: usb: lan78xx: Improve error handling in lan78xx_phy_wait_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <880eb763-74b0-4e89-a367-42d7804b526c@lunn.ch>
Date: Tue, 10 Dec 2024 03:11:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH net-next v1 09/11] net: usb: lan78xx: Improve error
 handling in lan78xx_phy_wait_not_busy

On Mon, Dec 09, 2024 at 02:07:49PM +0100, Oleksij Rempel wrote:
> Update `lan78xx_phy_wait_not_busy` to forward errors from
> `lan78xx_read_reg` instead of overwriting them with `-EIO`. Replace
> `-EIO` with `-ETIMEDOUT` for timeout cases, providing more specific and
> appropriate error codes.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  drivers/net/usb/lan78xx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index fdeb95db529b..9852526be002 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -961,14 +961,14 @@ static int lan78xx_phy_wait_not_busy(struct lan78xx_net *dev)
>  
>  	do {
>  		ret = lan78xx_read_reg(dev, MII_ACC, &val);
> -		if (unlikely(ret < 0))
> -			return -EIO;
> +		if (ret < 0)
> +			return ret;
>  
>  		if (!(val & MII_ACC_MII_BUSY_))
>  			return 0;
>  	} while (!time_after(jiffies, start_time + HZ));
>  
> -	return -EIO;
> +	return -ETIMEDOUT;

It would be better to replace this with an iopoll.h helper.

However, the change you made is O.K.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew