linux-kernel - Re: [PATCH net-next v1 11/11] net: usb: lan78xx: Improve error handling in WoL operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <189487eb-dfba-4d1b-ae62-c25a7e5574f1@lunn.ch>
Date: Tue, 10 Dec 2024 03:13:27 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH net-next v1 11/11] net: usb: lan78xx: Improve error
 handling in WoL operations

On Mon, Dec 09, 2024 at 02:07:51PM +0100, Oleksij Rempel wrote:
> Enhance error handling in Wake-on-LAN (WoL) operations:
> - Log a warning in `lan78xx_get_wol` if `lan78xx_read_reg` fails.
> - Check and handle errors from `device_set_wakeup_enable` and
>   `phy_ethtool_set_wol` in `lan78xx_set_wol`.
> - Ensure proper cleanup with a unified error handling path.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew