linux-kernel - Re: [PATCH] ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hfhsy6rvYQ87n68VZ7tySTe3GNaJAQ5n2mJtwYLHUEbw@mail.gmail.com>
Date: Tue, 10 Dec 2024 19:22:20 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Daniil Tatianin <d-tatianin@...dex-team.ru>
Cc: Robert Moore <robert.moore@...el.com>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Len Brown <lenb@...nel.org>, 
	Hans de Goede <hdegoede@...hat.com>, Erik Kaneda <erik.kaneda@...el.com>, linux-acpi@...r.kernel.org, 
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPICA: events/evxfregn: don't release the ContextMutex
 that was never acquired

On Fri, Nov 22, 2024 at 9:30 AM Daniil Tatianin
<d-tatianin@...dex-team.ru> wrote:
>
> This bug was first introduced in c27f3d011b08, where the author of the
> patch probably meant to do DeleteMutex instead of ReleaseMutex. The
> mutex leak was noticed later on and fixed in e4dfe108371, but the bogus
> MutexRelease line was never removed, so do it now.
>
> Link: https://github.com/acpica/acpica/pull/982
> Fixes: c27f3d011b08 ("Fix race in GenericSerialBus (I2C) and GPIO OpRegion parameter handling")
> Signed-off-by: Daniil Tatianin <d-tatianin@...dex-team.ru>
> ---
>  drivers/acpi/acpica/evxfregn.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/evxfregn.c b/drivers/acpi/acpica/evxfregn.c
> index 95f78383bbdb..bff2d099f469 100644
> --- a/drivers/acpi/acpica/evxfregn.c
> +++ b/drivers/acpi/acpica/evxfregn.c
> @@ -232,8 +232,6 @@ acpi_remove_address_space_handler(acpi_handle device,
>
>                         /* Now we can delete the handler object */
>
> -                       acpi_os_release_mutex(handler_obj->address_space.
> -                                             context_mutex);
>                         acpi_ut_remove_reference(handler_obj);
>                         goto unlock_and_exit;
>                 }
> --

Applied as 6.13-rc material, thanks!