linux-kernel - Re: [PATCH] Documentation: PM: Clarify pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j9JMPYGprbFdTX80d7ghE13ndcxR1ANcdLqj6yDU5nMg@mail.gmail.com>
Date: Tue, 10 Dec 2024 20:15:52 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Paul Barker <paul.barker.ct@...renesas.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, 
	Alan Stern <stern@...land.harvard.edu>, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: PM: Clarify pm_runtime_resume_and_get
 return value

On Tue, Dec 3, 2024 at 3:38 PM Paul Barker
<paul.barker.ct@...renesas.com> wrote:
>
> Update the documentation to match the behaviour of the code.
>
> The function pm_runtime_resume_and_get() always returns 0 on success,
> even if __pm_runtime_resume() returns 1.
>
> Fixes: 2c412337cfe6 ("PM: runtime: Add documentation for pm_runtime_resume_and_get()")
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>
> ---
>  Documentation/power/runtime_pm.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/power/runtime_pm.rst b/Documentation/power/runtime_pm.rst
> index 53d1996460ab..a86f1173980a 100644
> --- a/Documentation/power/runtime_pm.rst
> +++ b/Documentation/power/runtime_pm.rst
> @@ -347,7 +347,9 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h:
>
>    `int pm_runtime_resume_and_get(struct device *dev);`
>      - run pm_runtime_resume(dev) and if successful, increment the device's
> -      usage counter; return the result of pm_runtime_resume
> +      usage counter; returns 0 on success (whether or not the device's runtime
> +      PM status was already 'active') or the error code from pm_runtime_resume
> +      on failure.
>
>    `int pm_request_idle(struct device *dev);`
>      - submit a request to execute the subsystem-level idle callback for the
> --

Applied (with some minor adjustments) as 6.13-rc material, thanks!