linux-kernel - Re: [PATCH net] net: renesas: rswitch: fix initial MPIC register setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241210200115.GC2806@kernel.org>
Date: Tue, 10 Dec 2024 20:01:15 +0000
From: Simon Horman <horms@...nel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc: "nikita.yoush" <nikita.yoush@...entembedded.com>,
	Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michael Dege <michael.dege@...esas.com>,
	Christian Mardmoeller <christian.mardmoeller@...esas.com>,
	Dennis Ostermann <dennis.ostermann@...esas.com>
Subject: Re: [PATCH net] net: renesas: rswitch: fix initial MPIC register
 setting

On Tue, Dec 10, 2024 at 06:30:41AM +0000, Yoshihiro Shimoda wrote:
> Hello Nikita-san,
> 
> > From: Nikita Yushchenko, Sent: Monday, December 9, 2024 5:00 PM
> > 
> > MPIC.PIS must be set per phy interface type.
> > MPIC.LSC must be set per speed.
> > 
> > Do that strictly per datasheet, instead of hardcoding MPIC.PIS to GMII.
> > 
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> 
> Thank you for the patch! I could not apply this patch on net.git / main branch
> and the branch + your patches [1] though, this patch looks good. So,
> 
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> 
> [1]
> https://patchwork.kernel.org/project/netdevbpf/list/?series=915669

Hi Nikita,

I agree with Shimoda-san that this does not seem to apply cleanly to net.
Which is a requirement for our CI to run. Please rebase and repost.

-- 
pw-bot: changes-requested