linux-kernel - Re: [PATCH] bpftool: Fix failure with static linkage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241210201959.GA144421@e132581.arm.com>
Date: Tue, 10 Dec 2024 20:19:59 +0000
From: Leo Yan <leo.yan@....com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Quentin Monnet <qmo@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Nick Terrell <terrelln@...com>, bpf@...r.kernel.org,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mahe Tardy <mahe.tardy@...il.com>
Subject: Re: [PATCH] bpftool: Fix failure with static linkage

Hi Andrii,

On Tue, Dec 10, 2024 at 10:26:22AM -0800, Andrii Nakryiko wrote:

[...]

> > The tricky part is that static linkage works well without libzstd for
> > older versions of elfutils [1], but newer versions now require this
> > library. Which means that we don't want to link against libzstd
> > unconditionally, or users trying to build bpftool may have to install
> > unnecessary dependencies. Instead we should add a new probe under
> > tools/build/feature (Note that we already have several combinations in
> > there, libbfd, libbfd-liberty, libbfd-liberty-z, and I'm not sure what's
> > the best approach in terms of new combinations).
> >
> 
> So what's the conclusion here? Do we apply this as a fix, or someone
> needs to add more feature probing?

I am working on a new build feature.  Based on that, it will refine for
perf build and bpftool build.  Once get ready, I will send out for
review.

Thanks,
Leo