linux-kernel - Re: [PATCH] scripts/kernel-doc: Get -export option working again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pllz2r30.fsf@trenco.lwn.net>
Date: Tue, 10 Dec 2024 13:58:11 -0700
From: Jonathan Corbet <corbet@....net>
To: Akira Yokosawa <akiyks@...il.com>, Greg KH <gregkh@...uxfoundation.org>,
 Peter Zijlstra <peterz@...radead.org>, Masahiro Yamada
 <masahiroy@...nel.org>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Linus Torvalds
 <torvalds@...ux-foundation.org>, Akira Yokosawa <akiyks@...il.com>
Subject: Re: [PATCH] scripts/kernel-doc: Get -export option working again

Akira Yokosawa <akiyks@...il.com> writes:

> Since commit cdd30ebb1b9f ("module: Convert symbol namespace to string
> literal"), exported symbols marked by EXPORT_SYMBOL_NS(_GPL) are
> ignored by "kernel-doc -export" in fresh build of "make htmldocs".
>
> This is because regex in the perl script for those markers fails to
> match the new signatures:
>
>   - EXPORT_SYMBOL_NS(symbol, "ns");
>   - EXPORT_SYMBOL_NS_GPL(symbol, "ns");
>
> Update the regex so that it matches quoted string.
>
> Note: Escape sequence of \w is good for C identifiers, but can be
> too strict for quoted strings.  Instead, use \S, which matches any
> non-whitespace character, for compatibility with possible extension
> of namespace convention in the future [1].
>
> Fixes: cdd30ebb1b9f ("module: Convert symbol namespace to string literal")
> Link: https://lore.kernel.org/CAK7LNATMufXP0EA6QUE9hBkZMa6vJO6ZiaYuak2AhOrd2nSVKQ@mail.gmail.com/ [1]
> Signed-off-by: Akira Yokosawa <akiyks@...il.com>
> Cc: Masahiro Yamada <masahiroy@...nel.org>

Ah ... I should have thought of that ... I'm glad you did.  I've just
pushed the fix out to linux-next, will send it Linusward in the near
future.  Thanks for fixing this,

jon