linux-kernel - Re: [PATCH v2] arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360 separately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173386568810.497638.4312845461558580089.robh@kernel.org>
Date: Tue, 10 Dec 2024 15:42:06 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>, 
 Johan Hovold <johan@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
 Abel Vesa <abel.vesa@...aro.org>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 "Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-pmics: Enable all
 SMB2360 separately


On Tue, 10 Dec 2024 09:36:01 +0100, Stephan Gerhold wrote:
> At the moment, x1e80100-pmics.dtsi enables two of the SMB2360 PMICs by
> default and leaves the other two disabled. The third one was originally
> also enabled by default, but then disabled in commit a237b8da413c ("arm64:
> dts: qcom: x1e80100: Disable SMB2360_2 by default"). This is inconsistent
> and confusing. Some laptops will even need SMB2360_1 disabled by default if
> they just have a single USB-C port.
> 
> Make this consistent by keeping all SMB2360 disabled in x1e80100-pmics.dtsi
> and enable them separately for all boards where needed. That way it is
> always clear which ones are available and avoids accidentally trying to
> read/write from missing chips when some of the PMICs are not present.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
> Changes in v2:
> - Clarify commit message, there are actually two SMB2360 disabled by
>   default (3rd and 4th) and not just the third (Aiqun Yu (Maria))
> - Link to v1: https://lore.kernel.org/r/20241203-x1e80100-disable-smb2360-v1-1-80942b7f73da@linaro.org
> ---
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts               | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts      | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi               | 4 ++++
>  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 8 ++++++++
>  9 files changed, 68 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e001de-devkit.dtb qcom/x1e78100-lenovo-thinkpad-t14s.dtb qcom/x1e80100-asus-vivobook-s15.dtb qcom/x1e80100-crd.dtb qcom/x1e80100-dell-xps13-9345.dtb qcom/x1e80100-lenovo-yoga-slim7x.dtb qcom/x1e80100-qcp.dtb' for 20241210-x1e80100-disable-smb2360-v2-1-2449be2eca29@...aro.org:

arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: /soc@...eniqup@...000/i2c@...000/typec-mux@8: failed to match any schema with compatible: ['parade,ps8830']
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: /soc@...eniqup@...000/i2c@...000/typec-mux@8: failed to match any schema with compatible: ['parade,ps8830']
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: /soc@...eniqup@...000/i2c@...000/typec-mux@8: failed to match any schema with compatible: ['parade,ps8830']