linux-kernel - Re: [PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2kfapf6iolb65g3kss2hulwpqiczyyk6vvv37pqthm7o625umf@vuo7saus5kcy>
Date: Tue, 10 Dec 2024 23:41:44 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Jessica Zhang <quic_jesszhan@...cinc.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Andy Yan <andyshrk@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

Hello Jessica,

On Tue, Dec 10, 2024 at 09:45:09AM -0800, Jessica Zhang wrote:
> [...]
> > +static const struct raydium_rm67200_panel_info w552793baa_info = {
> > +	.mode = {
> > +		.clock = 132000,
> > +		.hdisplay = 1080,
> > +		.hsync_start = 1095,
> > +		.hsync_end = 1125,
> > +		.htotal = 1129,
> > +		.vdisplay = 1920,
> > +		.vsync_start = 1935,
> > +		.vsync_end = 1950,
> > +		.vtotal = 1952,
> > +		.width_mm = 68, /* 68.04mm */
> > +		.height_mm = 121, /* 120.96mm */
> > +		.type = DRM_MODE_TYPE_DRIVER,
> > +	},
> > +	.regulators = w552793baa_regulators,
> > +	.num_regulators = ARRAY_SIZE(w552793baa_regulators),
> > +	.panel_setup = w552793baa_setup,
> 
> Just curious, will there be other panels with different regulators and init
> commands added for this driver in the future?

I don't know any other RM67200 based panels. But the init sequence
contains lots of vendor specific registers and I'm pretty sure it
is specific to the W552793BAA. I put the regulators into the panel
specific section, because the datasheet for the RM67200 specifies
slightly different ones than the w552793baa datasheet. Thus I expect
that other displays might have slight differences.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)