[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0d64be76-7afe-416b-96f7-6ceb713c7ce0@ovn.org>
Date: Wed, 11 Dec 2024 00:16:51 +0100
From: Ilya Maximets <i.maximets@....org>
To: Vineeth Remanan Pillai <vineeth@...byteword.org>
Cc: i.maximets@....org, Peter Zijlstra <peterz@...radead.org>,
Joel Fernandes <joel@...lfernandes.org>, LKML
<linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>, vineethrp@...gle.com,
shraash@...gle.com, marcel.ziswiler@...ethink.co.uk
Subject: Re: [v6.12] WARNING: at kernel/sched/deadline.c:1995
enqueue_dl_entity (task blocked for more than 28262 seconds)
On 12/10/24 10:28, Ilya Maximets wrote:
> On 12/10/24 03:58, Vineeth Remanan Pillai wrote:
>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>> index fbdca89c677f..1f4b76c1f032 100644
>>> --- a/kernel/sched/fair.c
>>> +++ b/kernel/sched/fair.c
>>> @@ -1159,8 +1159,6 @@ static inline void update_curr_task(struct
>>> task_struct *p, s64 delta_exec)
>>> trace_sched_stat_runtime(p, delta_exec);
>>> account_group_exec_runtime(p, delta_exec);
>>> cgroup_account_cputime(p, delta_exec);
>>> - if (p->dl_server)
>>> - dl_server_update(p->dl_server, delta_exec);
>>> }
>>>
>>> static inline bool did_preempt_short(struct cfs_rq *cfs_rq, struct
>>> sched_entity *curr)
>>> @@ -1210,6 +1208,11 @@ s64 update_curr_common(struct rq *rq)
>>> return delta_exec;
>>> }
>>>
>>> +static inline bool dl_server_active(struct dl_sched_entity *dl_se)
>> Sorry a small typo in here. it should be struct sched_dl_entity and
>> not dl_sched_entity. The line should be:
>>
>> "static inline bool dl_server_active(struct sched_dl_entity *dl_se)"
>
> Sure. I can try that.
Running with this for about 8 hours and so far so good.
Will leave the test running for the night, just in case.
Best regards, Ilya Maximets.
>
> Note: I did indeed got lucky with the warning after 1 minute the
> first time. The second time I tried the system didn't show any
> issues up until 6 hours into the test...
>
> Best regards, Ilya Maximets.
>
Powered by blists - more mailing lists