linux-kernel - Re: [PATCH v4 2/2] crypto: hisilicon/sec2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1e2APBqSnl8ayyu@gondor.apana.org.au>
Date: Tue, 10 Dec 2024 11:31:12 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, liulongfang@...wei.com,
	qianweili@...wei.com, linwenkai6@...ilicon.com
Subject: Re: [PATCH v4 2/2] crypto: hisilicon/sec2 - fix for aead invalid
 authsize

On Fri, Nov 15, 2024 at 06:21:39PM +0800, Chenghai Huang wrote:
>
> +	a_ctx->fallback = false;

Is this field still used anywhere? If not please remove it.  It's
confusing to have two fallback fields.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt