linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241210033751.42239-1-sj@kernel.org>
Date: Mon,  9 Dec 2024 19:37:51 -0800
From: SeongJae Park <sj@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: SeongJae Park <sj@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the mm tree

On Mon, 9 Dec 2024 18:25:57 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 9 Dec 2024 17:08:29 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > After merging the mm tree, today's linux-next build (powerpc allyesconfig)
> > failed like this:
> > 
> > In file included from mm/damon/vaddr.c:736:
> > mm/damon/tests/vaddr-kunit.h: In function 'damon_test_three_regions_in_vmas':
> > mm/damon/tests/vaddr-kunit.h:92:1: error: the frame size of 3280 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> >    92 | }
> >       | ^
> > 
> > Presumably caused by commit
> > 
> >   062111898568 ("mm: move per-vma lock into vm_area_struct")
> > 
> 
> How about this?
> 
> 
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: mm/damon/tests/vaddr-kunit.h: reduce stack consumption
> Date: Mon Dec  9 06:20:01 PM PST 2024
> 
> After "mm: move per-vma lock into vm_area_struct" we're hitting
> 
> mm/damon/tests/vaddr-kunit.h: In function 'damon_test_three_regions_in_vmas':
> mm/damon/tests/vaddr-kunit.h:92:1: error: the frame size of 3280 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 
> Fix by moving all those vmas off the stack.
> 
> 
> Closes: https://lkml.kernel.org/r/20241209170829.11311e70@canb.auug.org.au
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: SeongJae Park <sj@...nel.org>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Reviewed-by: SeongJae Park <sj@...nel.org>

Thank you for this quick fix, Andrew.

> ---
> 
>  mm/damon/tests/vaddr-kunit.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/damon/tests/vaddr-kunit.h~mm-damon-tests-vaddr-kunith-reduce-stack-consumption
> +++ a/mm/damon/tests/vaddr-kunit.h
> @@ -68,7 +68,7 @@ static void damon_test_three_regions_in_
>  	static struct mm_struct mm;
>  	struct damon_addr_range regions[3] = {0};
>  	/* 10-20-25, 200-210-220, 300-305, 307-330 */
> -	struct vm_area_struct vmas[] = {
> +	static const struct vm_area_struct vmas[] = {
>  		(struct vm_area_struct) {.vm_start = 10, .vm_end = 20},
>  		(struct vm_area_struct) {.vm_start = 20, .vm_end = 25},
>  		(struct vm_area_struct) {.vm_start = 200, .vm_end = 210},
> _


Thanks,
SJ