linux-kernel - Re: [PATCH 2/2] clk: sophgo: Add clock controller support for SG2044 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412101358.czZY7XmR-lkp@intel.com>
Date: Tue, 10 Dec 2024 13:23:47 +0800
From: kernel test robot <lkp@...el.com>
To: Inochi Amaoto <inochiama@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Chen Wang <unicorn_wang@...look.com>,
	Inochi Amaoto <inochiama@...look.com>,
	Richard Cochran <richardcochran@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Yixun Lan <dlan@...too.org>,
	Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH 2/2] clk: sophgo: Add clock controller support for SG2044
 SoC

Hi Inochi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on sophgo/for-next]
[also build test WARNING on sophgo/fixes clk/clk-next robh/for-next linus/master v6.13-rc2 next-20241209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Inochi-Amaoto/dt-bindings-clock-sophgo-add-clock-controller-for-SG2044/20241209-162418
base:   https://github.com/sophgo/linux.git for-next
patch link:    https://lore.kernel.org/r/20241209082132.752775-3-inochiama%40gmail.com
patch subject: [PATCH 2/2] clk: sophgo: Add clock controller support for SG2044 SoC
config: parisc-randconfig-r053-20241210 (https://download.01.org/0day-ci/archive/20241210/202412101358.czZY7XmR-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412101358.czZY7XmR-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/clk/sophgo/clk-sg2044.c:133:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.
>> drivers/clk/sophgo/clk-sg2044.c:149:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

vim +133 drivers/clk/sophgo/clk-sg2044.c

   126	
   127	static unsigned long sg2044_pll_calc_vco_rate(unsigned long parent_rate,
   128						      unsigned long refdiv,
   129						      unsigned long fbdiv)
   130	{
   131		u64 numerator = parent_rate * fbdiv;
   132	
 > 133		do_div(numerator, refdiv);
   134	
   135		return numerator;
   136	}
   137	
   138	static unsigned long sg2044_pll_calc_rate(unsigned long parent_rate,
   139						  unsigned long refdiv,
   140						  unsigned long fbdiv,
   141						  unsigned long postdiv1,
   142						  unsigned long postdiv2)
   143	{
   144		u64 numerator, denominator;
   145	
   146		numerator = parent_rate * fbdiv;
   147		denominator = refdiv * (postdiv1 + 1) * (postdiv2 + 1);
   148	
 > 149		do_div(numerator, denominator);
   150	
   151		return numerator;
   152	}
   153	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki