linux-kernel - Re: [PATCH v3] staging: rtl8723bs: remove code depending on cflag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21d2d3f7-c94a-454b-92b4-2eb6a4be6ce9@stanley.mountain>
Date: Tue, 10 Dec 2024 10:28:48 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, philipp.g.hortmann@...il.com,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH v3] staging: rtl8723bs: remove code depending on cflag

On Mon, Dec 09, 2024 at 06:33:36PM -0300, Rodrigo Gobbi wrote:
> > The commit message should answer any kind of reasonable questions
> > a review is probably going to ask but it doesn't give any information on
> > this.
> 
> I'll try to improve this for future patches, tks for pointing that out.
> 
> > This commit would easier to review if it were broken up in a different
> > way.
> 
> Ok, in that way, a patch series is the best approach here, right?

I'm not your boss, right?  And I can't tell you what to do and what I'm
suggesting is more work.  If you just want to send patch 1 from the
series instead of all three patches, that's fine.  No one is going to
be annoyed by that.

In patch 1, you would only delete code which is obviously surrounded
by #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA so the case statement would
look like:

	case HAL_DEF_DBG_RX_INFO_DUMP:
		break;

It's basically the same as what you wrote but slightly smaller and
easier to review.  But yeah, we're not going to merge this as-is.

> Despite the changes in the series being dependent on each other in this case.

Yep.  Patchsets are generally dependent on each other.  The rule is that
each patch has to make sense on its own.  You can't break the build.  But
they work on top of each other and they're applied in order.

regards,
dan carpenter