linux-kernel - Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nNRv9SeEi6Bt2jZLd5UkUAqRVX-XjaL-yP56LWR+g00ig@mail.gmail.com>
Date: Tue, 10 Dec 2024 13:35:41 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Maxim Levitsky <mlevitsk@...hat.com>
Cc: kvm@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
	Haiyang Zhang <haiyangz@...rosoft.com>, 
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>, linux-hyperv@...r.kernel.org, 
	Dexuan Cui <decui@...rosoft.com>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, 
	Konstantin Taranov <kotaranov@...rosoft.com>, Leon Romanovsky <leon@...nel.org>, 
	"K. Y. Srinivasan" <kys@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, Shradha Gupta <shradhagupta@...ux.microsoft.com>, 
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, 
	Eric Dumazet <edumazet@...gle.com>, Long Li <longli@...rosoft.com>, 
	Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs

On Mon, Dec 9, 2024 at 11:28 PM Maxim Levitsky <mlevitsk@...hat.com> wrote:
>
> Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> doesn't free this temporary array in the success path.
>
> This was caught by kmemleak.
>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>

LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>


-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)