linux-kernel - Re: [PATCH] ASoC: dt-bindings: convert rt5682.txt to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <uedkwiuuwi3tfqvi3zzcnays4ytl7l2phg5g6wqwire6ywc2ce@goouwpzb5hi6>
Date: Tue, 10 Dec 2024 10:29:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Bard Liao <bardliao@...ltek.com>, linux-sound@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: convert rt5682.txt to dt-schema

On Wed, Dec 04, 2024 at 11:52:34AM +0100, Neil Armstrong wrote:
> +  realtek,dmic-delay-ms:
> +    description:
> +      Set the delay time (ms) for the requirement of the particular DMIC.
> +
> +  realtek,amic-delay-ms:
> +    description:
> +      Set the delay time (ms) for the requirement of the particular platform or AMIC.

Please wrap at 80.

This wasn't present in the old binding, so mention reason of adding it
in the commit msg.

> +
> +  realtek,dmic-clk-driving-high:
> +    type: boolean
> +    description:
> +      Set the high driving of the DMIC clock out.
> +
> +  clocks:
> +    items:
> +      - description: phandle and clock specifier for codec MCLK.

...

> +
> +  DBVDD-supply:
> +    description: Regulator supplying I/O power through the DBVDD pin.
> +
> +  LDO1-IN-supply:
> +    description: Regulator supplying power to the digital core and charge pump
> +      through the LDO1_IN pin.
> +
> +unevaluatedProperties: false

And since I expect a new version: please move unevaluatedProps after
required: block.

> +
> +required:
> +  - compatible
> +  - reg
> +  - AVDD-supply
> +  - VBAT-supply
> +  - MICVDD-supply
> +  - DBVDD-supply
> +  - LDO1-IN-supply


Best regards,
Krzysztof