linux-kernel - Re: [PATCH] kbuild: Drop architecture argument from headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAR8dy-=EcsZFb-tjXSk2sK7sHrV0WSSV4E8dzRh5Veceg@mail.gmail.com>
Date: Tue, 10 Dec 2024 19:13:24 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, 
	Andrew Morton <akpm@...ux-foundation.org>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: Drop architecture argument from headers_check.pl

On Tue, Dec 10, 2024 at 5:52 PM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> Since commit 7ff0fd4a9e20cf73 ("kbuild: drop support for

This is not a fixed commit hash because Andrew Morton
does not use 'git request-pull'

I will squash this to the original patch.


> include/asm-<arch> in headers_check.pl"), the second argument $arch is
> no longer used, hence drop it.
>
> Reported-by: Masahiro Yamada <masahiroy@...nel.org>
> Closes: https://lore.kernel.org/CAK7LNARNa3NPSeRAUgMaEqWiA+C6-s1PxRe1bCUJg6zLyOtDkA@mail.gmail.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Commit 7ff0fd4a9e20cf73 is part of the mm tree.
>
>  usr/include/Makefile         | 2 +-
>  usr/include/headers_check.pl | 5 ++---
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 771e32872b2ab12d..6c6de1b1622b1a69 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -78,7 +78,7 @@ quiet_cmd_hdrtest = HDRTEST $<
>        cmd_hdrtest = \
>                 $(CC) $(c_flags) -fsyntax-only -x c /dev/null \
>                         $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
> -               $(PERL) $(src)/headers_check.pl $(obj) $(SRCARCH) $<; \
> +               $(PERL) $(src)/headers_check.pl $(obj) $<; \
>                 touch $@
>
>  $(obj)/%.hdrtest: $(obj)/%.h FORCE
> diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
> index 7070c891ea294b4d..2b70bfa5558e6451 100755
> --- a/usr/include/headers_check.pl
> +++ b/usr/include/headers_check.pl
> @@ -3,9 +3,8 @@
>  #
>  # headers_check.pl execute a number of trivial consistency checks
>  #
> -# Usage: headers_check.pl dir arch [files...]
> +# Usage: headers_check.pl dir [files...]
>  # dir:   dir to look for included files
> -# arch:  architecture
>  # files: list of files to check
>  #
>  # The script reads the supplied files line by line and:
> @@ -23,7 +22,7 @@ use warnings;
>  use strict;
>  use File::Basename;
>
> -my ($dir, $arch, @files) = @ARGV;
> +my ($dir, @files) = @ARGV;
>
>  my $ret = 0;
>  my $line;
> --
> 2.34.1
>


-- 
Best Regards
Masahiro Yamada