linux-kernel - Re: [PATCH 1/8] of/irq: Fix wrong value of variable @len in of_irq_parse_imap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bcf5847-6f54-4bfb-8752-e121d15ea1ff@icloud.com>
Date: Tue, 10 Dec 2024 18:46:48 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Rob Herring <robh@...nel.org>
Cc: Saravana Kannan <saravanak@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>,
 Stefan Wiehler <stefan.wiehler@...ia.com>,
 Grant Likely <grant.likely@...aro.org>, Tony Lindgren <tony@...mide.com>,
 Kumar Gala <galak@...eaurora.org>, Thierry Reding
 <thierry.reding@...il.com>, Julia Lawall <Julia.Lawall@...6.fr>,
 Jamie Iles <jamie@...ieiles.com>, Grant Likely <grant.likely@...retlab.ca>,
 Benjamin Herrenschmidt <benh@...nel.crashing.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Rob Herring <rob.herring@...xeda.com>, Zijun Hu <quic_zijuhu@...cinc.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH 1/8] of/irq: Fix wrong value of variable @len in
 of_irq_parse_imap_parent()

On 2024/12/10 04:56, Rob Herring wrote:
> Applied, but rewrote the commit message:
> 
> of/irq: Fix interrupt-map cell length check in of_irq_parse_imap_parent()
> 
> On a malformed interrupt-map property which is shorter than expected by 
> 1 cell, we may read bogus data past the end of the property instead of
> returning an error in of_irq_parse_imap_parent().
> 
> Decrement the remaining length when skipping over the interrupt parent  
> phandle cell.

thank you Rob for these good corrections.