linux-kernel - Re: [PATCH 01/12] mm/filemap: change filemap_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1giRw7nEebrPfpN@infradead.org>
Date: Tue, 10 Dec 2024 03:13:11 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Jens Axboe <axboe@...nel.dk>
Cc: linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, hannes@...xchg.org,
	clm@...a.com, linux-kernel@...r.kernel.org, willy@...radead.org,
	kirill@...temov.name, bfoster@...hat.com
Subject: Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take
 a struct kiocb

On Tue, Dec 03, 2024 at 08:31:37AM -0700, Jens Axboe wrote:
> +static int filemap_create_folio(struct kiocb *iocb,
> +		struct address_space *mapping, struct folio_batch *fbatch)

We might as well drop passing the mapping and deriving it from the iocb
as well.

Otherwise this looks fine to me.