linux-kernel - Re: [PATCH 11/11] x86/cpu: Make all all CPUID leaf names consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210111959.GEZ1gj36ksqWNoBO0b@fat_crate.local>
Date: Tue, 10 Dec 2024 12:19:59 +0100
From: Borislav Petkov <bp@...en8.de>
To: Dave Hansen <dave.hansen@...el.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, tglx@...utronix.de, rafael@...nel.org,
	lenb@...nel.org
Subject: Re: [PATCH 11/11] x86/cpu: Make all all CPUID leaf names consistent

On Thu, Oct 31, 2024 at 10:19:37AM -0700, Dave Hansen wrote:
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index a5f221ea5688..b44dbb952d8c 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1001,8 +1001,8 @@ void get_cpu_cap(struct cpuinfo_x86 *c)
>  	}
>  
>  	/* Extended state features: level 0x0000000d */
> -	if (c->cpuid_level >= 0x0000000d) {
> -		cpuid_count(0x0000000d, 1, &eax, &ebx, &ecx, &edx);
> +	if (c->cpuid_level >= CPUID_LEAF_XSTATE) {
> +		cpuid_count(CPUID_LEAF_XSTATE, 1, &eax, &ebx, &ecx, &edx);
>  
>  		c->x86_capability[CPUID_D_1_EAX] = eax;

Yah, I'll take whatever I can get. You should add this hunk to your set.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette