linux-kernel - Re: [PATCH] irqchip/loongarch-avec:Add multi-nodes topology support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca4b3c85-1df9-521b-012d-69d18fc06c98@loongson.cn>
Date: Tue, 10 Dec 2024 09:29:28 +0800
From: Tianyang Zhang <zhangtianyang@...ngson.cn>
To: Thomas Gleixner <tglx@...utronix.de>, Huacai Chen <chenhuacai@...nel.org>
Cc: kernel@...0n.name, loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/loongarch-avec:Add multi-nodes topology support

Hi, Thomas

在 2024/12/9 上午4:22, Thomas Gleixner 写道:
> On Sat, Dec 07 2024 at 17:11, Huacai Chen wrote:
>> On Sat, Dec 7, 2024 at 11:31 AM Tianyang Zhang
>> <zhangtianyang@...ngson.cn> wrote:
>>> This patch enables the advanced interrupt controller function under
>>> multiple-node of 3C600. The topology of the advanced interrupt controller
>>> is consistent with NUMA node. We check the enable status of the node where
>>> each CPU is located once when it goes online, which may cause some
>>> additional operations, but it can ensure that the advanced interrupt
>>> controller can still be used in situations where some CPUs cannot start
>> The whole can be reworded:
>>
>> Currently we only enable one chip's advanced interrupt controller
>> (AVEC) in hardware, so multi-chip machines with Loongson-3C6000 don't
>> work. This patch enables it for every chip (In theory every chip needs
>> to be enabled only once, but for simplicity we enable it on every core
>> in the CPU online hooks).
> It want's to be reworded without 'we' and 'this patch':
>
>    avecintc_init() enables the Advanced Interrupt Controller (AVEC) of
>    the boot CPU node, but nothing enables the AVEC on secondary nodes.
>
>    Move the enablement to the CPU hotplug callback so that secondary
>    nodes get the AVEC enabled too. In theory enabling it once per node
>    would be sufficient, but redundant enabling does no hard, so keep the
>    code simple and do it unconditionally.
>
> Thanks,
>
>          tglx
Ok, I got it , thanks