linux-kernel - Re: [PATCH mm-unstable 04/17] mm: alpha: Introduce arch_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412102123.Db7EAmhx-lkp@intel.com>
Date: Tue, 10 Dec 2024 19:35:09 +0800
From: kernel test robot <lkp@...el.com>
To: Kalesh Singh <kaleshsingh@...gle.com>, akpm@...ux-foundation.org,
	vbabka@...e.cz, yang@...amperecomputing.com, riel@...riel.com,
	david@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, linux@...linux.org.uk,
	tsbogend@...ha.franken.de, James.Bottomley@...senpartnership.com,
	ysato@...rs.sourceforge.jp, dalias@...c.org,
	glaubitz@...sik.fu-berlin.de, davem@...emloft.net,
	andreas@...sler.com, tglx@...utronix.de, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, chris@...kel.net,
	jcmvbkbc@...il.com, bhelgaas@...gle.com, jason.andryuk@....com,
	leitao@...ian.org, linux-alpha@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org,
	loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH mm-unstable 04/17] mm: alpha: Introduce arch_mmap_hint()

Hi Kalesh,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kalesh-Singh/mm-Introduce-generic_mmap_hint/20241210-104424
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241210024119.2488608-5-kaleshsingh%40google.com
patch subject: [PATCH mm-unstable 04/17] mm: alpha: Introduce arch_mmap_hint()
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20241210/202412102123.Db7EAmhx-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241210/202412102123.Db7EAmhx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412102123.Db7EAmhx-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/alpha/kernel/osf_sys.c: In function 'arch_get_unmapped_area':
>> arch/alpha/kernel/osf_sys.c:1280:24: error: 'hint' undeclared (first use in this function); did you mean 'uint'?
    1280 |                 return hint;
         |                        ^~~~
         |                        uint
   arch/alpha/kernel/osf_sys.c:1280:24: note: each undeclared identifier is reported only once for each function it appears in


vim +1280 arch/alpha/kernel/osf_sys.c

  1248	
  1249	unsigned long
  1250	arch_get_unmapped_area(struct file *filp, unsigned long addr,
  1251			       unsigned long len, unsigned long pgoff,
  1252			       unsigned long flags, vm_flags_t vm_flags)
  1253	{
  1254		unsigned long limit;
  1255	
  1256		/* "32 bit" actually means 31 bit, since pointers sign extend.  */
  1257		if (current->personality & ADDR_LIMIT_32BIT)
  1258			limit = 0x80000000;
  1259		else
  1260			limit = TASK_SIZE;
  1261	
  1262		if (len > limit)
  1263			return -ENOMEM;
  1264	
  1265		if (flags & MAP_FIXED)
  1266			return addr;
  1267	
  1268		/* First, see if the given suggestion fits.
  1269	
  1270		   The OSF/1 loader (/sbin/loader) relies on us returning an
  1271		   address larger than the requested if one exists, which is
  1272		   a terribly broken way to program.
  1273	
  1274		   That said, I can see the use in being able to suggest not
  1275		   merely specific addresses, but regions of memory -- perhaps
  1276		   this feature should be incorporated into all ports?  */
  1277	
  1278		addr = arch_mmap_hint(filp, addr, len, pgoff, flags);
  1279		if (addr)
> 1280			return hint;
  1281	
  1282		/* Next, try allocating at TASK_UNMAPPED_BASE.  */
  1283		addr = arch_get_unmapped_area_1 (PAGE_ALIGN(TASK_UNMAPPED_BASE),
  1284						 len, limit);
  1285		if (addr != (unsigned long) -ENOMEM)
  1286			return addr;
  1287	
  1288		/* Finally, try allocating in low memory.  */
  1289		addr = arch_get_unmapped_area_1 (PAGE_SIZE, len, limit);
  1290	
  1291		return addr;
  1292	}
  1293	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki