linux-kernel - Re: [PATCH] extcon: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2rfj7ohbduvtnjga4bnmjfb7m2bn7j7nnjhvakr63mqf2htzvf@n7wrknk5yfyi>
Date: Tue, 10 Dec 2024 12:36:06 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Chanwoo Choi <chanwoo@...nel.org>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, Andy Shevchenko <andy@...nel.org>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH] extcon: Switch back to struct platform_driver::remove()

Hello,

On Sun, Dec 08, 2024 at 09:49:16PM +0900, Chanwoo Choi wrote:
> On Wed, Nov 27, 2024 at 6:30 PM Uwe Kleine-König
> <u.kleine-koenig@...libre.com> wrote:
> > diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c
> > index 805a47230689..529ac5898e38 100644
> > --- a/drivers/extcon/extcon-usbc-cros-ec.c
> > +++ b/drivers/extcon/extcon-usbc-cros-ec.c
> > @@ -525,12 +525,12 @@ MODULE_DEVICE_TABLE(of, extcon_cros_ec_of_match);
> >
> >  static struct platform_driver extcon_cros_ec_driver = {
> >         .driver = {
> > -               .name  = "extcon-usbc-cros-ec",
> > +               .name = "extcon-usbc-cros-ec",
> 
> If there is  no change, this line is changed.
> Please don't touch this line.

I'm not 100% sure I understand what you say here. I guess you oppose to
fix the coding style as a side product of my patch.

Note that it's probably easiest to just not apply my patch as Linus
Torvalds fixed all .remove_new in his tree generating conflicts if
subsystems take similar patches.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)