linux-kernel - [PATCH iwl-next] fixup! devlink: add devlink_fmsg_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241210115620.3141094-1-mateusz.polchlopek@intel.com>
Date: Tue, 10 Dec 2024 12:56:20 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: intel-wired-lan@...ts.osuosl.org,
	anthony.l.nguyen@...el.com
Cc: apw@...onical.com,
	joe@...ches.com,
	dwaipayanray1@...il.com,
	lukas.bulwahn@...il.com,
	akpm@...ux-foundation.org,
	willemb@...gle.com,
	edumazet@...gle.com,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
	Simon Horman <horms@...nel.org>
Subject: [PATCH iwl-next] fixup! devlink: add devlink_fmsg_dump_skb() function

Hello Tony!

In the commit related to "devlink-health dump" the sparse reports new issue.
It has been also reported some time ago by Simon:
https://lore.kernel.org/netdev/20240822104007.GL2164@kernel.org/

Please squash this change into to devlink-health series, the link for the
last sent version is here:
https://lore.kernel.org/netdev/20240821133714.61417-1-przemyslaw.kitszel@intel.com/

Thanks in advance
Mateusz

CC: Simon Horman <horms@...nel.org>
Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
---
 net/devlink/health.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/devlink/health.c b/net/devlink/health.c
index 3f6241d51007..57db6799722a 100644
--- a/net/devlink/health.c
+++ b/net/devlink/health.c
@@ -1270,7 +1270,7 @@ void devlink_fmsg_dump_skb(struct devlink_fmsg *fmsg, const struct sk_buff *skb)
 			 has_trans ? skb_network_header_len(skb) : -1);
 	devlink_fmsg_put(fmsg, "transport hdr",
 			 has_trans ? skb->transport_header : -1);
-	devlink_fmsg_put(fmsg, "csum", skb->csum);
+	devlink_fmsg_put(fmsg, "csum", (__force u32)skb->csum);
 	devlink_fmsg_put(fmsg, "csum_ip_summed", (u8)skb->ip_summed);
 	devlink_fmsg_put(fmsg, "csum_complete_sw", !!skb->csum_complete_sw);
 	devlink_fmsg_put(fmsg, "csum_valid", !!skb->csum_valid);
-- 
2.38.1