linux-kernel - Re: [PATCH 0/3] sunrpc: Deadcoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03fff89e9df7d04eaa1a793c289b5126f145e46a.camel@kernel.org>
Date: Tue, 10 Dec 2024 07:26:20 -0500
From: Jeff Layton <jlayton@...nel.org>
To: linux@...blig.org, trondmy@...nel.org, anna@...nel.org, 
 chuck.lever@...cle.com, neilb@...e.de, okorniev@...hat.com,
 Dai.Ngo@...cle.com,  tom@...pey.com
Cc: linux-nfs@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 netdev@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] sunrpc: Deadcoding

On Tue, 2024-12-10 at 01:02 +0000, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> Hi,
>   This is a bunch of deadcoding around the sunrpc code.
> This all removes whole functions/definitions/files
> rather than changing any actual codepaths.
> 
> Dave
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> 
> Dr. David Alan Gilbert (3):
>   sunrpc: Remove unused xprt_iter_get_xprt
>   sunrpc: Remove gss_generic_token deadcode
>   sunrpc: Remove gss_{de,en}crypt_xdr_buf deadcode
> 
>  include/linux/sunrpc/gss_asn1.h         |  81 ---------
>  include/linux/sunrpc/gss_krb5.h         |   1 -
>  include/linux/sunrpc/xprtmultipath.h    |   1 -
>  net/sunrpc/auth_gss/Makefile            |   2 +-
>  net/sunrpc/auth_gss/gss_generic_token.c | 231 ------------------------
>  net/sunrpc/auth_gss/gss_krb5_crypto.c   |  55 ------
>  net/sunrpc/auth_gss/gss_krb5_internal.h |   7 -
>  net/sunrpc/auth_gss/gss_mech_switch.c   |   1 -
>  net/sunrpc/xprtmultipath.c              |  17 --
>  9 files changed, 1 insertion(+), 395 deletions(-)
>  delete mode 100644 include/linux/sunrpc/gss_asn1.h
>  delete mode 100644 net/sunrpc/auth_gss/gss_generic_token.c
> 

I love removing unused code. Assuming everything builds OK after this:

Reviewed-by: Jeff Layton <jlayton@...nel.org>