linux-kernel - Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1g1afPM1RRwD_EH@kekkonen.localdomain>
Date: Tue, 10 Dec 2024 12:34:49 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Ricardo Ribalda Delgado <ribalda@...nel.org>
Cc: git@...tzsch.eu, Mauro Carvalho Chehab <mchehab@...nel.org>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Vincent Knecht <vincent.knecht@...loo.org>
Subject: Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank
 controls

On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado wrote:
> > > +               state = v4l2_subdev_get_locked_active_state(&imx214->sd);
> >
> > Sakari, I see that other drivers assume that the active is locked in
> > set_ctrl. Is this correct?
> 
> imx214->sd.state_lock = imx214->ctrls.lock;
> 
> So I guess it is fine :)

Yes, it is.

Please also run this on the set:

$ ./scripts/checkpatch.pl --strict --max-line-length=80

-- 
Sakari Ailus